Re: can someone explain me why this was changed?

On Fri, Oct 16, 2009 at 12:19 AM, Martin Radosta <martinradosta@gmail.com> wrote:

Check this mark-story commit:

http://code.cakephp.org/commits/view/332f6add6a97bdf738f8d1d71106834c82a46dc7#highlight

specialy this line (710):
if (in_array($options['type'], array('date', 'datetime'))) {

was changed by this line (710):
if ($options['type'] === 'date' || $options['type'] === 'datetime') {

[..snip..]

Perhaps Mark made the change to check on the type? Then again, this can be achieved by specifying 'true' as the third argument to in_array() so yeah, not sure why the change was made (unless he didn't know about the optional third argument to in_array())

- GS

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "CakePHP" group.
To post to this group, send email to cake-php@googlegroups.com
To unsubscribe from this group, send email to cake-php+unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.com/group/cake-php?hl=en
-~----------~----~----~----~------~----~------~--~---