twitter: linux.kernel - 26 new messages in 23 topics

linux.kernel
http://groups.google.com/group/linux.kernel?hl=en

Today's topics:

* Constify struct sysfs_ops for 2.6.32 v1 - 2 messages, 2 authors
http://groups.google.com/group/linux.kernel/t/a9348bc8ee8e2c83?hl=en
* pathconf(3) with _PC_LINK_MAX - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/46220ecfa591ab99?hl=en
* arch/xtensa/platforms/iss: correct size computation - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/bbe78f538f7a34b5?hl=en
* security/selinux/ss: correct size computation - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/81c22c33d256951c?hl=en
* drivers/clocksource: correct size computation - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/08e9c8ed896a08d5?hl=en
* tools/perf/util: correct size computation - 2 messages, 1 author
http://groups.google.com/group/linux.kernel/t/09f52438010e5a7a?hl=en
* x86: Fix typo in arch/x86/mm/kmmio.c - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e2c2c83278f10426?hl=en
* drivers/infiniband: correct size computation - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/ceee31341b5a27d4?hl=en
* Сергей Белов has added you as a friend on the website VK.com - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/8f76b166b6dea25c?hl=en
* tracing: Fix trace_marker output - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/59b320cbcd591edd?hl=en
* X86: use explicit register name for get/put_user - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e7edf1911621d4e8?hl=en
* linux-next: manual merge of the pcmcia tree with the pxa tree - 1 messages,
1 author
http://groups.google.com/group/linux.kernel/t/69b830c08023c562?hl=en
* KVM updates for the 2.6.33 merge window - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/78fb3c1597852142?hl=en
* genirq updates for 2.6.33 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/a28837dee3c9f122?hl=en
* timers core for 2.6.33 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/1c530f91b88f56d2?hl=en
* timers ntp updates for 2.6.33 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/18aece6d30ed7d7f?hl=en
* timers hpet updates for 2.6.33 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/f83bf3730f8c3e0e?hl=en
* timers urgent for 2.6.33 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/93244eca365ec582?hl=en
* Unable to use tools/perf sched and timechart correctly - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/9da002544ae8f440?hl=en
* cfq-iosched: reduce write depth only if sync was delayed - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/85566d72f71c5737?hl=en
* block updates for 2.6.33-rc1 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/2f2d15dbdbf00428?hl=en
* perf: Remove pointless union that wraps the hw breakpoint fields - 2
messages, 1 author
http://groups.google.com/group/linux.kernel/t/3a307b6ec6a9e4d9?hl=en
* perf/sched: fix for getting task's execute time - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/feeb303886efcf24?hl=en

==============================================================================
TOPIC: Constify struct sysfs_ops for 2.6.32 v1
http://groups.google.com/group/linux.kernel/t/a9348bc8ee8e2c83?hl=en
==============================================================================

== 1 of 2 ==
Date: Sun, Dec 6 2009 1:00 am
From: Pekka Enberg

On Sat, 2009-12-05 at 22:15 +0100, Jens Axboe wrote:
> On Sat, Dec 05 2009, Emese Revfy wrote:
> > From: Emese Revfy <re.emese@gmail.com>
> >
> > Constify struct sysfs_ops.
> > Per Dave Miller's suggestion, resend with proper CC list and patch format.
>
> For the block parts:
>
> Acked-by: Jens Axboe <jens.axboe@oracle.com>

For the SLUB parts:

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== 2 of 2 ==
Date: Sun, Dec 6 2009 1:30 am
From: Jiri Slaby

On 12/06/2009 03:38 AM, Emese Revfy wrote:
> Jiri Slaby wrote:
>> Apart you CCed hundreds of people
>
> I looked up the maintainers of the patched files from the kernel sources
> because I didn't know a better way to let everyone affected know.

Well, if you had per subsystem patches, you would Cc only relevant
people per patch.

>> and mixed thousand things together into one patch,
>
> I thought that the best way is to have one patch contain changes for
> a single structure type only.

The problem is that probably nobody will pick them up. Or you would need
to collect Acks from all participants and run with these to Andrew
Morton. Then it's up to him if he wants to merge them. If you split
them, you can ask concrete maintainers for a merge.

--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: pathconf(3) with _PC_LINK_MAX
http://groups.google.com/group/linux.kernel/t/46220ecfa591ab99?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:10 am
From: hooanon05@yahoo.co.jp

Al Viro:
> Um... Why do we need that, again? Note that there is no way whatsoever
> for predicting whether link(2) will fail due to having too many existing
> links before you attempt the call - links can be created or removed between
> stat(2) and link(2). So any uses of that value are heuristical.
>
> Can you actually show any use cases of that thing? Preferably - in existing
> code, but even a theoretical one would be interesting.

Thanx for quick reply.
To be honest, I am unsure how important this is in real world.
But I've met (reported, precisly) such test program. It seems to come
from old X/Open, though the actual reporter tried the LSB (Linux
Standard Base) runtime-test.

You can get the source code from
ftp.freestandards.org/pub/lsb/test_suites/released-3.2/source/runtime/lsb-test-core-3.2.0-2.src.rpm
+ lsb-test-core-3.2.0.tar.gz
+ lts_vsx-pcts-3.2.0.tgz
+ tset/POSIX.os/files/link/link.c

Here I quote just a part from tset/POSIX.os/files/link/link.c,
The function tblink() behaves as a wrapper for link(2) with the error
checking.
When the filesystem is unknown to pathconf(_PC_LINK_MAX), 'link_max' may
be incorrect and LSB cannot pass this test.

test15()
{
creat(t15a_file, MODEANY);
link_max = pathconf(t15a_file, _PC_LINK_MAX);

/* create lesser of LINK_MAX and PCTS_LINK_MAX links successfully */
/* i.e. make (testmax-1) link() calls, as there is 1 link already */

testmax = link_max;
for (i = 0; i < testmax-1; i++)
{
(void) sprintf(links[i], "L%ld", i+1);
if (tblink(t15a_file, links[i], SUCCEED, NOERROR) != SUCCEED)
break;
}

/* if LINK_MAX is testable, next link gives EMLINK */

(void) tblink(t15a_file, t15b_file, SYSERROR, EMLINK);
}

J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: arch/xtensa/platforms/iss: correct size computation
http://groups.google.com/group/linux.kernel/t/bbe78f538f7a34b5?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:20 am
From: Julia Lawall

From: Julia Lawall <julia@diku.dk>

The size argument to alloc_bootmem should be the size of desired structure,
not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
arch/xtensa/platforms/iss/network.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c
index 2f0b86b..54a0868 100644
--- a/arch/xtensa/platforms/iss/network.c
+++ b/arch/xtensa/platforms/iss/network.c
@@ -780,7 +780,8 @@ static int iss_net_setup(char *str)
return 1;
}

- if ((new = alloc_bootmem(sizeof new)) == NULL) {
+ new = alloc_bootmem(sizeof(*new));
+ if (new == NULL) {
printk("Alloc_bootmem failed\n");
return 1;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: security/selinux/ss: correct size computation
http://groups.google.com/group/linux.kernel/t/81c22c33d256951c?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:20 am
From: Julia Lawall

From: Julia Lawall <julia@diku.dk>

The size argument to kcalloc should be the size of desired structure,
not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
security/selinux/ss/services.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/security/selinux/ss/services.c b/security/selinux/ss/services.c
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -2555,7 +2555,7 @@ int security_get_classes(char ***classes
read_lock(&policy_rwlock);

*nclasses = policydb.p_classes.nprim;
- *classes = kcalloc(*nclasses, sizeof(*classes), GFP_ATOMIC);
+ *classes = kcalloc(*nclasses, sizeof(**classes), GFP_ATOMIC);
if (!*classes)
goto out;

@@ -2602,7 +2602,7 @@ int security_get_permissions(char *class
}

*nperms = match->permissions.nprim;
- *perms = kcalloc(*nperms, sizeof(*perms), GFP_ATOMIC);
+ *perms = kcalloc(*nperms, sizeof(**perms), GFP_ATOMIC);
if (!*perms)
goto out;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: drivers/clocksource: correct size computation
http://groups.google.com/group/linux.kernel/t/08e9c8ed896a08d5?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:20 am
From: Julia Lawall

From: Julia Lawall <julia@diku.dk>

The size argument to ioremap_nocache should be the size of desired
information, not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
drivers/clocksource/cyclone.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff -u -p a/drivers/clocksource/cyclone.c b/drivers/clocksource/cyclone.c
--- a/drivers/clocksource/cyclone.c
+++ b/drivers/clocksource/cyclone.c
@@ -50,7 +50,7 @@ static int __init init_cyclone_clocksour

/* find base address: */
offset = CYCLONE_CBAR_ADDR;
- reg = ioremap_nocache(offset, sizeof(reg));
+ reg = ioremap_nocache(offset, sizeof(*reg));
if (!reg) {
printk(KERN_ERR "Summit chipset: Could not find valid CBAR register.\n");
return -ENODEV;
@@ -65,7 +65,7 @@ static int __init init_cyclone_clocksour

/* setup PMCC: */
offset = base + CYCLONE_PMCC_OFFSET;
- reg = ioremap_nocache(offset, sizeof(reg));
+ reg = ioremap_nocache(offset, sizeof(*reg));
if (!reg) {
printk(KERN_ERR "Summit chipset: Could not find valid PMCC register.\n");
return -ENODEV;
@@ -75,7 +75,7 @@ static int __init init_cyclone_clocksour

/* setup MPCS: */
offset = base + CYCLONE_MPCS_OFFSET;
- reg = ioremap_nocache(offset, sizeof(reg));
+ reg = ioremap_nocache(offset, sizeof(*reg));
if (!reg) {
printk(KERN_ERR "Summit chipset: Could not find valid MPCS register.\n");
return -ENODEV;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: tools/perf/util: correct size computation
http://groups.google.com/group/linux.kernel/t/09f52438010e5a7a?hl=en
==============================================================================

== 1 of 2 ==
Date: Sun, Dec 6 2009 1:20 am
From: Julia Lawall

From: Julia Lawall <julia@diku.dk>

The size argument to zalloc should be the size of desired structure,
not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
tools/perf/util/parse-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -197,7 +197,7 @@ struct tracepoint_path *tracepoint_id_to
if (id == config) {
closedir(evt_dir);
closedir(sys_dir);
- path = zalloc(sizeof(path));
+ path = zalloc(sizeof(*path));
path->system = malloc(MAX_EVENT_LENGTH);
if (!path->system) {
free(path);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== 2 of 2 ==
Date: Sun, Dec 6 2009 1:30 am
From: tip-bot for Julia Lawall

Commit-ID: 59b4caeb797494043f5f3b98a610f5d9b75eefa3
Gitweb: http://git.kernel.org/tip/59b4caeb797494043f5f3b98a610f5d9b75eefa3
Author: Julia Lawall <julia@diku.dk>
AuthorDate: Sun, 6 Dec 2009 10:16:30 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 6 Dec 2009 10:21:59 +0100

perf tools: Correct size computation in tracepoint_id_to_path()

The size argument to zalloc should be the size of desired
structure, not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <Pine.LNX.4.64.0912061016120.20858@ask.diku.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/util/parse-events.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 9e5dbd6..448a13b 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -197,7 +197,7 @@ struct tracepoint_path *tracepoint_id_to_path(u64 config)
if (id == config) {
closedir(evt_dir);
closedir(sys_dir);
- path = zalloc(sizeof(path));
+ path = zalloc(sizeof(*path));
path->system = malloc(MAX_EVENT_LENGTH);
if (!path->system) {
free(path);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: x86: Fix typo in arch/x86/mm/kmmio.c
http://groups.google.com/group/linux.kernel/t/e2c2c83278f10426?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:20 am
From: tip-bot for Shaun Patterson

Commit-ID: 8055039c2a2454c7159dcbde3161943b757a6e0e
Gitweb: http://git.kernel.org/tip/8055039c2a2454c7159dcbde3161943b757a6e0e
Author: Shaun Patterson <shaunpatterson@gmail.com>
AuthorDate: Sat, 5 Dec 2009 10:41:34 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 6 Dec 2009 09:23:40 +0100

x86: Fix typo in arch/x86/mm/kmmio.c

Signed-off-by: Shaun Patterson <shaunpatterson@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: pq@iki.fi
LKML-Reference: <1260027694.10074.170.camel@linux-4lgc.site>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/kmmio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
index 16ccbd7..72f1572 100644
--- a/arch/x86/mm/kmmio.c
+++ b/arch/x86/mm/kmmio.c
@@ -490,7 +490,7 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
* 2. remove_kmmio_fault_pages()
* Remove the pages from kmmio_page_table.
* 3. rcu_free_kmmio_fault_pages()
- * Actally free the kmmio_fault_page structs as with RCU.
+ * Actually free the kmmio_fault_page structs as with RCU.
*/
void unregister_kmmio_probe(struct kmmio_probe *p)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: drivers/infiniband: correct size computation
http://groups.google.com/group/linux.kernel/t/ceee31341b5a27d4?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:20 am
From: Julia Lawall

From: Julia Lawall <julia@diku.dk>

The size argument to ioremap_nocache should be the size of desired
information, not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
<+...
-sizeof(x)
+sizeof(*x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
drivers/infiniband/hw/nes/nes.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c
index cbde0cf..b8c5372 100644
--- a/drivers/infiniband/hw/nes/nes.c
+++ b/drivers/infiniband/hw/nes/nes.c
@@ -521,7 +521,8 @@ static int __devinit nes_probe(struct pci_dev *pcidev, const struct pci_device_i
spin_lock_init(&nesdev->indexed_regs_lock);

/* Remap the PCI registers in adapter BAR0 to kernel VA space */
- mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), sizeof(mmio_regs));
+ mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0),
+ sizeof(*mmio_regs));
if (mmio_regs == NULL) {
printk(KERN_ERR PFX "Unable to remap BAR0\n");
ret = -EIO;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: Сергей Белов has added you as a friend on the website VK.com
http://groups.google.com/group/linux.kernel/t/8f76b166b6dea25c?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:30 am
From: VK

linux-kernel,

Сергей Белов has added you as a friend on the website VK.com

You can log in and view your friends` pages using your email and automatically created password: 1MjAo0pu

VK.com is a website that helps dozens of millions of people find their old friends, share photos and events and always stay in touch.

To log in, please follow this link:
http://vkontakte.ru/login.php?regemail=linux-kernel@vger.kernel.org#1MjAo0pu

You can change your password in Settings.

Attention: If you ignore this invitation, your registration will not be activated.

Good luck!Best regards,
VK Administration

==============================================================================
TOPIC: tracing: Fix trace_marker output
http://groups.google.com/group/linux.kernel/t/59b320cbcd591edd?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:40 am
From: Carsten Emde

Olof,

> On Sun, Nov 22, 2009 at 10:24:48AM +0000, tip-bot for Carsten Emde wrote:
>> Commit-ID: c13d2f7c3231e873f30db92b96c8caa48f100f33
>> Gitweb: http://git.kernel.org/tip/c13d2f7c3231e873f30db92b96c8caa48f100f33
>> Author: Carsten Emde<Carsten.Emde@osadl.org>
>> AuthorDate: Mon, 16 Nov 2009 20:56:13 +0100
>> Committer: Steven Rostedt<rostedt@goodmis.org>
>> CommitDate: Tue, 17 Nov 2009 09:19:06 -0500
>> tracing: Fix trace_marker output
>> When a string was written to<debugfs>/tracing/trace_marker, some
>> strange characters appeared in the trace output instead of the
>> string, since a vprint function erroneously called a vararg print
>> function with a va_list argument. This patch fixes the problem and
>> simplifies the related code.
>
> [...]
>
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 03c7fd5..12b49ca 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -1361,10 +1361,11 @@ int trace_array_vprintk(struct trace_array *tr,
>> pause_graph_tracing();
>> raw_local_irq_save(irq_flags);
>> __raw_spin_lock(&trace_buf_lock);
>> - len = vsnprintf(trace_buf, TRACE_BUF_SIZE, fmt, args);
>> -
>> - len = min(len, TRACE_BUF_SIZE-1);
>> - trace_buf[len] = 0;
>> + if (args == NULL) {
>> + strncpy(trace_buf, fmt, TRACE_BUF_SIZE);
>> + len = strlen(trace_buf);
>> + } else
>> + len = vsnprintf(trace_buf, TRACE_BUF_SIZE, fmt, args);
> Comparing a va_list with NULL is bogus. It's supposed to be treated like
> an opaque type and only be manipulated with va_* accessors.
>
> I wouldn't really care much, but it broke builds on some ARM platforms:
>
> kernel/trace/trace.c: In function 'trace_array_vprintk':
> kernel/trace/trace.c:1364: error: invalid operands to binary == (have 'va_list' and 'void *')
> kernel/trace/trace.c: In function 'tracing_mark_write':
> kernel/trace/trace.c:3349: error: incompatible type for argument 3 of 'trace_vprintk'
Oops, sorry. Didn't know that the gcc warn/error level is so much
different across platforms.

>[..]
> Oh, and I haven't had a chance to actually test and make sure it does
> what is expected, since I don't have a testcase for it.
The testcase is:
# cd /sys/kernel/debug/tracing/
[root@deliv1 tracing]# echo "I am a marker" >trace_marker
[root@deliv1 tracing]# tail -1 trace
bash-6347 [002] 303160.793532: 0: I am a marker

> + ret = trace_vprintk(ip, "%s", ap);
This prevents the '%' character to be used in an output string. If used,
it may horribly crash the kernel.

I'll investigate the situation further and try to come back with a
better solution.

Carsten.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: X86: use explicit register name for get/put_user
http://groups.google.com/group/linux.kernel/t/e7edf1911621d4e8?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 1:40 am
From: Jiri Slaby

I couldn't find any traces of documentation for the behavior used
in current get/put_user implementation. After the merge of
32/64-bit version there is back register reference ("0") to the
output register ("a"). The output is retval of int type, but
the value in the input may be a long on 64-bit.

I don't know if this could ever cause any problems, but changing
the input to an explicit register ("a") makes it cleaner in my eyes.
There is no need of the back reference.

Change this for both get and put_user.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
arch/x86/include/asm/uaccess.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index abd3e0e..35f483b 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -122,7 +122,7 @@ extern int __get_user_bad(void);
#define __get_user_x(size, ret, x, ptr) \
asm volatile("call __get_user_" #size \
: "=a" (ret), "=d" (x) \
- : "0" (ptr)) \
+ : "a" (ptr)) \

/* Careful: we have to cast the result to the type of the pointer
* for sign reasons */
@@ -181,7 +181,7 @@ extern int __get_user_bad(void);

#define __put_user_x(size, x, ptr, __ret_pu) \
asm volatile("call __put_user_" #size : "=a" (__ret_pu) \
- : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")
+ : "a" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")

--
1.6.5.3

==============================================================================
TOPIC: linux-next: manual merge of the pcmcia tree with the pxa tree
http://groups.google.com/group/linux.kernel/t/69b830c08023c562?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 2:00 am
From: Marc Zyngier

On Mon, 30 Nov 2009 09:48:13 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

Hi Russell,

> What would be a better idea is to rework the driver once my changes
> have hit. If you need to pass additional data around, you can do it
> like this:

Now that your changes are in Linus' tree, I started looking at
restructuring my code. I sense a small problem though:

[...]
> for (i = 0; i < nr; i++) {
> skts[i].skt.nr = i;
> skts[i].skt.ops = &my_ops;
> skts[i].skt.socket.owner = THIS_MODULE;
> skts[i].skt.socket.parent = &dev->dev;
> skts[i].skt.socket.pci_irq = the_socket_irq;
> ret = pxa2xx_drv_pcmcia_add_one(&skts[i].skt);

Unless I'm mistaken, it seems that pxa2xx_drv_pcmcia_add_one() doesn't
call pxa2xx_configure_sockets(), leaving the sockets disabled.

There is several ways to solve this one:
- Add the call to pxa2xx_configure_sockets() to _add_one()
- Do the MECR access in the pxa2xx_viper driver,
- export pxa2xx_configure_sockets() and do the call locally.

What would be your preferred solution?

M.
--
I'm the slime oozin' out from your TV set...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: KVM updates for the 2.6.33 merge window
http://groups.google.com/group/linux.kernel/t/78fb3c1597852142?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 2:00 am
From: Avi Kivity

Linus, please pull from

git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.33

to receive the KVM updates for the 2.6.33 merge window.

Highlights:
- improved kernel context switching speed
- better interoperation with other users of virtualization extensions
- improved irq scaling
- nested svm improvements and tracing
- improved cpufreq integration
- spin loop detection on newer hardware

Notes:
- this update depends on, and thus merges, tip's x86/entry branch (user
return notifiers)
- kvm/ppc64 support will be merged through the powerpc tree

Shortlog/diffstat:

Alexander Graf (2):
KVM: Activate Virtualization On Demand
KVM: SVM: Notify nested hypervisor of lost event injections

Arnd Bergmann (1):
KVM: Enable 32bit dirty log pointers on 64bit host

Avi Kivity (17):
core, x86: Add user return notifiers
x86: Fix user return notifier build
core: Fix user return notifier on fork()
Merge remote branch 'tip/x86/entry' into kvm-updates/2.6.33
KVM: Don't wrap schedule() with vcpu_put()/vcpu_load()
KVM: Don't pass kvm_run arguments
KVM: Return -ENOTTY on unrecognized ioctls
KVM: Move assigned device code to own file
KVM: VMX: Move MSR_KERNEL_GS_BASE out of the vmx autoload msr area
KVM: x86 shared msr infrastructure
KVM: VMX: Use shared msr infrastructure
KVM: VMX: Remove vmx->msr_offset_efer
KVM: Allow internal errors reported to userspace to carry extra data
KVM: VMX: Report unexpected simultaneous exceptions as internal
errors
KVM: x86 emulator: limit instructions to 15 bytes
KVM: Drop user return notifier when disabling virtualization on a cpu
KVM: VMX: Fix comparison of guest efer with stale host value

Carsten Otte (2):
KVM: s390: Make psw available on all exits, not just a subset
KVM: s390: Fix prefix register checking in arch/s390/kvm/sigp.c

Ed Swierk (1):
KVM: Xen PV-on-HVM guest support

Eduardo Habkost (3):
KVM: VMX: Use macros instead of hex value on cr0 initialization
KVM: SVM: Reset cr0 properly on vcpu reset
KVM: SVM: init_vmcb(): remove redundant save->cr0 initialization

Glauber Costa (2):
KVM: x86: include pvclock MSRs in msrs_to_save
KVM: allow userspace to adjust kvmclock offset

Gleb Natapov (10):
KVM: Call pic_clear_isr() on pic reset to reuse logic there
KVM: Move irq sharing information to irqchip level
KVM: Change irq routing table to use gsi indexed array
KVM: Maintain back mapping from irqchip/pin to gsi
KVM: Move irq routing data structure to rcu locking
KVM: Move irq ack notifier list to arch independent code
KVM: Convert irq notifiers lists to RCU locking
KVM: Move IO APIC to its own lock
KVM: Drop kvm->irq_lock lock from irq injection path
KVM: remove duplicated task_switch check

Hollis Blanchard (1):
KVM: powerpc: Fix BUILD_BUG_ON condition

Huang Weiyi (1):
KVM: remove duplicated #include

Jan Kiszka (8):
KVM: x86: Refactor guest debug IOCTL handling
KVM: x86: Rework guest single-step flag injection and filtering
KVM: x86: Drop unneeded CONFIG_HAS_IOMEM check
KVM: x86: Fix guest single-stepping while interruptible
KVM: SVM: Cleanup NMI singlestep
KVM: x86: Polish exception injection via KVM_SET_GUEST_DEBUG
KVM: Reorder IOCTLs in main kvm.h
KVM: x86: Add KVM_GET/SET_VCPU_EVENTS

Jiri Slaby (1):
KVM: fix lock imbalance in kvm_*_irq_source_id()

Joerg Roedel (11):
KVM: SVM: reorganize svm_interrupt_allowed
KVM: SVM: don't copy exit_int_info on nested vmrun
KVM: SVM: Remove remaining occurences of rdtscll
KVM: SVM: Move INTR vmexit out of atomic code
KVM: SVM: Add tracepoint for nested vmrun
KVM: SVM: Add tracepoint for nested #vmexit
KVM: SVM: Add tracepoint for injected #vmexit
KVM: SVM: Add tracepoint for #vmexit because intr pending
KVM: SVM: Add tracepoint for invlpga instruction
KVM: SVM: Add tracepoint for skinit instruction
KVM: SVM: Remove nsvm_printk debugging code

Juan Quintela (1):
KVM: remove pre_task_link setting in save_state_to_tss16

Marcelo Tosatti (9):
KVM: SVM: remove needless mmap_sem acquision from nested_svm_map
KVM: x86: disable paravirt mmu reporting
KVM: VMX: fix handle_pause declaration
KVM: fix irq_source_id size verification
KVM: VMX: move CR3/PDPTR update to vmx_set_cr3
KVM: MMU: update invlpg handler comment
KVM: x86: disallow multiple KVM_CREATE_IRQCHIP
KVM: x86: disallow KVM_{SET,GET}_LAPIC without allocated
in-kernel lapic
KVM: only clear irq_source_id if irqchip is present

Mark Langsdorf (1):
KVM: SVM: Support Pause Filter in AMD processors

Mohammed Gamal (5):
KVM: x86 emulator: Add 'push/pop sreg' instructions
KVM: x86 emulator: Introduce No64 decode option
KVM: x86 emulator: Add missing decoder flags for 'or' instructions
KVM: x86 emulator: Add pusha and popa instructions
KVM: VMX: Enhance invalid guest state emulation

Sheng Yang (1):
KVM: VMX: Disable unrestricted guest when EPT disabled

Stephen Rothwell (1):
x86: Fix user return notifier put_cpu_var() invocation

Zachary Amsden (5):
KVM: Separate timer intialization into an indepedent function
KVM: Kill the confusing tsc_ref_khz and ref_freq variables
KVM: Fix printk name error in svm.c
KVM: Fix hotplug of CPUs
KVM: x86: Harden against cpufreq

Zhai, Edwin (2):
KVM: introduce kvm_vcpu_on_spin
KVM: VMX: Add support for Pause-Loop Exiting

--
error compiling committee.c: too many arguments to function

==============================================================================
TOPIC: genirq updates for 2.6.33
http://groups.google.com/group/linux.kernel/t/a28837dee3c9f122?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 2:10 am
From: Thomas Gleixner

Linus,

Please pull the latest irq-core-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq-core-for-linus

Thanks,

tglx

------------------>
Luis Henriques (1):
genirq: do not execute DEBUG_SHIRQ when irq setup failed

kernel/irq/manage.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1516ab7..8c68d5b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -768,7 +768,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
kfree(action);

#ifdef CONFIG_DEBUG_SHIRQ
- if (irqflags & IRQF_SHARED) {
+ if (!retval && (irqflags & IRQF_SHARED)) {
/*
* It's a shared IRQ -- the driver ought to be prepared for it
* to happen immediately, so let's make sure....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

==============================================================================
TOPIC: timers core for 2.6.33
http://groups.google.com/group/linux.kernel/t/1c530f91b88f56d2?hl=en
==============================================================================

== 1 of 1 ==
Date: Sun, Dec 6 2009 2:10 am
From: Thomas Gleixner

Linus,

Please pull the latest timers-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-for-linus

Thanks,

tglx

------------------>
H Hartley Sweeten (1):
clockevents: Add missing include to pacify sparse

John Stultz (2):
time: Implement logarithmic time accumulation
time: Remove xtime_cache

Jon Hunter (2):
nohz: Prevent clocksource wrapping during idle
nohz: Allow 32-bit machines to sleep for more than 2.15 seconds

Martin Schwidefsky (2):
nohz: Reuse ktime in sub-functions of tick_check_idle.
nohz: Introduce arch_needs_cpu

Mike Travis (1):
timers, init: Limit the number of per cpu calibration bootup messages

Stanislaw Gruszka (1):
posix-cpu-timers: optimize and document timer_create callback

Stephen Rothwell (1):
sparc: fix printk for change of variable type

Thomas Gleixner (8):
clockevents: Use u32 for mult and shift factors
clocksource: Provide a generic mult/shift factor calculation
mips: Use generic mult/shift factor calculation for clocks
nohz: Type cast printk argument
nohz: Track last do_timer() cpu
clocksource/events: Fix fallout of generic code changes
x86: Fix printk format due to variable type change
x86: vmiclock: Fix printk format

diff --git a/arch/mips/include/asm/time.h b/arch/mips/include/asm/time.h
index df6a430..c7f1bfe 100644
--- a/arch/mips/include/asm/time.h
+++ b/arch/mips/include/asm/time.h
@@ -84,8 +84,16 @@ static inline int init_mips_clocksource(void)

twitter

Sunday, December 6, 2009

linux.kernel - 26 new messages in 23 topics - digest

0 Comments:

Post a Comment

About Me

Previous Posts