linux.kernel - 25 new messages in 13 topics - digest
linux.kernel
http://groups.google.com/group/linux.kernel?hl=en
Today's topics:
* mfd: Add support for the timberdale FPGA. - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/d01182830d6bf0f5?hl=en
* linux-next: manual merge of the omap_dss2 tree with the omap tree - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/6301abd44550ec77?hl=en
* HID: make raw reports possible for both feature and output reports - 7
messages, 2 authors
http://groups.google.com/group/linux.kernel/t/24254d069a593af0?hl=en
* tracing: add tracing support for compat syscalls - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/22202c3dcd1a3591?hl=en
* syscalls: add define syscall prefix macro - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/8c59e185364b1e8d?hl=en
* perf tools: using O_LARGEFILE to open perf data file - fix - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/5e0297b0b8d16155?hl=en
* arm: mxc: TrustZone interrupt controller (TZIC) for i.MX5 family - 3
messages, 1 author
http://groups.google.com/group/linux.kernel/t/281ca1a532ca6d76?hl=en
* [PATCH] perf_events, x86: PEBS support - 4 messages, 2 authors
http://groups.google.com/group/linux.kernel/t/0acdc85baea49653?hl=en
* bitops: compile time optimization for hweight_long(CONSTANT) - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/f58ac10e7917a328?hl=en
* WARNING: at arch/x86/kernel/hpet.c:404 hpet_next_event+0x7d/0x90() - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/7453481db3a15b1d?hl=en
* [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is
used - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e208566420ffb479?hl=en
* drivers/media/video/hdpvr: introduce missing kfree - 2 messages, 2 authors
http://groups.google.com/group/linux.kernel/t/1d900bfc8d616cd8?hl=en
* slub: ARCH_SLAB_MINALIGN defaults to 8 on x86_32. is this too big? - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/90562c9ef16cf2a0?hl=en
==============================================================================
TOPIC: mfd: Add support for the timberdale FPGA.
http://groups.google.com/group/linux.kernel/t/d01182830d6bf0f5?hl=en
==============================================================================
== 1 of 1 ==
Date: Wed, Feb 3 2010 4:40 am
From: Samuel Ortiz
On Wed, Feb 03, 2010 at 10:53:34AM +0000, Richard Röjfors wrote:
> On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
> > Hi Richard,
> >
> > On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard Röjfors wrote:
> >> The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
> >> russelville.
> >>
> >> The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
> >> to a number of platform devices for each IP inside the FPGA.
> >>
> >> Signed-off-by: Richard Röjfors<richard.rojfors@pelagicore.com>
> > The patch looks good to me, I have a couple of minor comments though:
> >
> > - Please replace most of your printk with dev_dbg/err()
>
> Agreed.
>
> > - Please fix your checkpatch output:
> > total: 255 errors, 18 warnings, 822 lines checked
>
> Sweet, the mail client changed all tabs to spaces when resending the patch.
Actually, your first patch to the linux-media ml also had tabs changed into
spaces.
Cheers,
Samuel.
> --Richard
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
==============================================================================
TOPIC: linux-next: manual merge of the omap_dss2 tree with the omap tree
http://groups.google.com/group/linux.kernel/t/6301abd44550ec77?hl=en
==============================================================================
== 1 of 1 ==
Date: Wed, Feb 3 2010 4:40 am
From: Grazvydas Ignotas
hi,
On Wed, Feb 3, 2010 at 6:29 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Tomi,
>
> Today's linux-next merge of the omap_dss2 tree got a conflict in
> arch/arm/mach-omap2/board-omap3pandora.c between commit
> f8b6f704105164eac7c043a48f79c4234e03e4b2 ("omap: Rename hsmmc symbols to
> reflect independence from twl4030") from the omap tree and commit
> aacb4387a1e6f3b57977375532c6d8e47fcd5652 ("OMAP: pandora: add DSS2
> support and related regulators") from the omap_dss2 tree.
I've rebased my patch against linux-omap/for-next (attached). To fix
the conflict, Tomi can rebase his queue on linux-omap/for-next, or
Tony can simply take this to his queue - this has no "hard"
dependencies on other queued DSS2 changes, has only board file changes
and builds fine in linux-omap/for-next. I would prefer the second
option, as I plan sending more boardfile changes to linux-omap.
>
> I fixed it up (see below) and can carry the fix as necessary.
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
>
> diff --cc arch/arm/mach-omap2/board-omap3pandora.c
> index 9967b5d,bd3e577..0000000
> --- a/arch/arm/mach-omap2/board-omap3pandora.c
> +++ b/arch/arm/mach-omap2/board-omap3pandora.c
> @@@ -192,7 -193,62 +193,62 @@@ static struct twl4030_keypad_data pando
> .rep = 1,
> };
>
> + static struct omap_dss_device pandora_lcd_device = {
> + .name = "lcd",
> + .driver_name = "tpo_td043mtea1_panel",
> + .type = OMAP_DISPLAY_TYPE_DPI,
> + .phy.dpi.data_lines = 24,
> + .reset_gpio = 157,
> + };
> +
> + static struct omap_dss_device pandora_tv_device = {
> + .name = "tv",
> + .driver_name = "venc",
> + .type = OMAP_DISPLAY_TYPE_VENC,
> + .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO,
> + };
> +
> + static struct omap_dss_device *pandora_dss_devices[] = {
> + &pandora_lcd_device,
> + &pandora_tv_device,
> + };
> +
> + static struct omap_dss_board_info pandora_dss_data = {
> + .num_devices = ARRAY_SIZE(pandora_dss_devices),
> + .devices = pandora_dss_devices,
> + .default_device = &pandora_lcd_device,
> + };
> +
> + static struct platform_device pandora_dss_device = {
> + .name = "omapdss",
> + .id = -1,
> + .dev = {
> + .platform_data = &pandora_dss_data,
> + },
> + };
> +
> + static struct regulator_consumer_supply pandora_vcc_lcd_supply = {
> + .supply = "vcc",
> + .dev = &pandora_lcd_device.dev,
> + };
> +
> + static struct regulator_consumer_supply pandora_vdda_dac_supply = {
> + .supply = "vdda_dac",
> + .dev = &pandora_dss_device.dev,
> + };
> +
> + static struct regulator_consumer_supply pandora_vdds_supplies[] = {
> + {
> + .supply = "vdds_sdi",
> + .dev = &pandora_dss_device.dev,
> + },
> + {
> + .supply = "vdds_dsi",
> + .dev = &pandora_dss_device.dev,
> + },
> + };
> +
> -static struct twl4030_hsmmc_info omap3pandora_mmc[] = {
> +static struct omap2_hsmmc_info omap3pandora_mmc[] = {
> {
> .mmc = 1,
> .wires = 4,
>
==============================================================================
TOPIC: HID: make raw reports possible for both feature and output reports
http://groups.google.com/group/linux.kernel/t/24254d069a593af0?hl=en
==============================================================================
== 1 of 7 ==
Date: Wed, Feb 3 2010 4:50 am
From: Jiri Kosina
In commit 2da31939a42 ("Bluetooth: Implement raw output support for HIDP
layer"), support for Bluetooth hid_output_raw_report was added, but it
pushes the data to the intr socket instead of the ctrl one. This has been
fixed by 6bf8268f9a91f1 ("Bluetooth: Use the control channel for raw HID reports")
Still, it is necessary to distinguish whether the report in question should be
either FEATURE or OUTPUT. For this, we have to extend the generic HID API,
so that hid_output_raw_report() callback provides means to specify this
value so that it can be passed down to lower level hardware drivers (currently
Bluetooth and USB).
Based on original patch by Bastien Nocera <hadess@hadess.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/hidraw.c | 2 +-
drivers/hid/usbhid/hid-core.c | 5 +++--
include/linux/hid.h | 2 +-
net/bluetooth/hidp/core.c | 13 ++++++++++---
4 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index cdd1369..d044767 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -134,7 +134,7 @@ static ssize_t hidraw_write(struct file *file, const char __user *buffer, size_t
goto out;
}
- ret = dev->hid_output_raw_report(dev, buf, count);
+ ret = dev->hid_output_raw_report(dev, buf, count, HID_OUTPUT_REPORT);
out:
kfree(buf);
return ret;
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index e2997a8..caa16c0 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -774,7 +774,8 @@ static int hid_alloc_buffers(struct usb_device *dev, struct hid_device *hid)
return 0;
}
-static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t count)
+static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t count,
+ unsigned char report_type)
{
struct usbhid_device *usbhid = hid->driver_data;
struct usb_device *dev = hid_to_usb_dev(hid);
@@ -785,7 +786,7 @@ static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t co
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
HID_REQ_SET_REPORT,
USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
- ((HID_OUTPUT_REPORT + 1) << 8) | *buf,
+ ((report_type + 1) << 8) | *buf,
interface->desc.bInterfaceNumber, buf + 1, count - 1,
USB_CTRL_SET_TIMEOUT);
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 8709365..3661a62 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -501,7 +501,7 @@ struct hid_device { /* device report descriptor */
void (*hiddev_report_event) (struct hid_device *, struct hid_report *);
/* handler for raw output data, used by hidraw */
- int (*hid_output_raw_report) (struct hid_device *, __u8 *, size_t);
+ int (*hid_output_raw_report) (struct hid_device *, __u8 *, size_t, unsigned char);
/* debugging support via debugfs */
unsigned short debug;
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 6cf526d..9c88750 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -313,10 +313,17 @@ static int hidp_send_report(struct hidp_session *session, struct hid_report *rep
return hidp_queue_report(session, buf, rsize);
}
-static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, size_t count)
+static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, size_t count,
+ unsigned char report_type)
{
- if (hidp_send_ctrl_message(hid->driver_data,
- HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE,
+ if (report_type == HID_FEATURE_REPORT)
+ report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE;
+ else if (report_type == HID_OUTPUT_REPORT)
+ report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;
+ else
+ return -EINVAL;
+
+ if (hidp_send_ctrl_message(hid->driver_data, report_type,
data, count))
return -ENOMEM;
return count;
--
1.6.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 2 of 7 ==
Date: Wed, Feb 3 2010 4:50 am
From: Jiri Kosina
On Wed, 3 Feb 2010, Jiri Kosina wrote:
> > > The USB HID core sends a GET_DESCRIPTOR request for the Report
> > > descriptor, which isn't practical here because that descriptor is only
> > > available through SDP.
> >
> > And we only do SDP queries in user-space...
> >
> > If you're not going to work on it shortly, I can take a look at cooking
> > a patch by the end of the week. Otherwise, I'd be happy testing your
> > patches.
I have now rebased the three patches on top of 6bf8268f9a91f1
("Bluetooth: Use the control channel for raw HID reports") which has
already landed in Linus' tree. I will send them as a followup to this
mail.
If you have any changes/acks/nacks, please let me know.
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 3 of 7 ==
Date: Wed, Feb 3 2010 5:00 am
From: Jiri Kosina
From: Bastien Nocera <hadess@hadess.net>
Now that hid_output_raw_report works, port the PS3 Sixaxis
Bluetooth quirk from user-space, into kernel-space.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-sony.c | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index eabe5f8..f7f80e1 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1340,6 +1340,7 @@ static const struct hid_device_id hid_blacklist[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGX_MOUSE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SUNPLUS, USB_DEVICE_ID_SUNPLUS_WDESKTOP) },
{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb300) },
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 4e84502..08b7fa0 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -73,6 +73,12 @@ static int sony_set_operational(struct hid_device *hdev)
return ret;
}
+static int sony_set_operational_bt(struct hid_device *hdev)
+{
+ unsigned char buf[] = { 0x53, 0xf4, 0x42, 0x03, 0x00, 0x00 };
+ return hdev->hid_output_raw_report(hdev, buf, sizeof(buf), HID_FEATURE_REPORT);
+}
+
static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
{
int ret;
@@ -101,7 +107,13 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
goto err_free;
}
- ret = sony_set_operational(hdev);
+ if (hdev->bus == BUS_USB)
+ ret = sony_set_operational(hdev);
+ else if (hdev->bus == BUS_BLUETOOTH)
+ ret = sony_set_operational_bt(hdev);
+ else
+ ret = 0;
+
if (ret < 0)
goto err_stop;
@@ -121,6 +133,7 @@ static void sony_remove(struct hid_device *hdev)
static const struct hid_device_id sony_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGX_MOUSE),
.driver_data = VAIO_RDESC_CONSTANT },
{ }
--
1.6.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 4 of 7 ==
Date: Wed, Feb 3 2010 5:00 am
From: Jiri Kosina
From: Bastien Nocera <hadess@hadess.net>
The hid-wacom driver required user-space to poke at the tablet
to make it send data about the cursor location.
This patch makes it do the same thing but in the kernel.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/hid-wacom.c | 27 +++++++++++++++++++++++++++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index 12dcda5..d7897b5 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -156,7 +156,9 @@ static int wacom_probe(struct hid_device *hdev,
struct hid_input *hidinput;
struct input_dev *input;
struct wacom_data *wdata;
+ char rep_data[2];
int ret;
+ int limit;
wdata = kzalloc(sizeof(*wdata), GFP_KERNEL);
if (wdata == NULL) {
@@ -166,6 +168,7 @@ static int wacom_probe(struct hid_device *hdev,
hid_set_drvdata(hdev, wdata);
+ /* Parse the HID report now */
ret = hid_parse(hdev);
if (ret) {
dev_err(&hdev->dev, "parse failed\n");
@@ -178,6 +181,30 @@ static int wacom_probe(struct hid_device *hdev,
goto err_free;
}
+ /* Set Wacom mode2 */
+ rep_data[0] = 0x03; rep_data[1] = 0x00;
+ limit =3;
+ do {
+ ret = hdev->hid_output_raw_report(hdev, rep_data, 2,
+ HID_FEATURE_REPORT);
+ } while (ret < 0 && limit-- > 0);
+ if (ret < 0) {
+ dev_err(&hdev->dev, "failed to poke device #1, %d\n", ret);
+ goto err_free;
+ }
+
+ /* 0x06 - high reporting speed, 0x05 - low speed */
+ rep_data[0] = 0x06; rep_data[1] = 0x00;
+ limit = 3;
+ do {
+ ret = hdev->hid_output_raw_report(hdev, rep_data, 2,
+ HID_FEATURE_REPORT);
+ } while (ret < 0 && limit-- > 0);
+ if (ret < 0) {
+ dev_err(&hdev->dev, "failed to poke device #2, %d\n", ret);
+ goto err_free;
+ }
+
hidinput = list_entry(hdev->inputs.next, struct hid_input, list);
input = hidinput->input;
--
1.6.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 5 of 7 ==
Date: Wed, Feb 3 2010 6:20 am
From: Marcel Holtmann
Hi Jiri,
> Now that hid_output_raw_report works, port the PS3 Sixaxis
> Bluetooth quirk from user-space, into kernel-space.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
> - ret = sony_set_operational(hdev);
> + if (hdev->bus == BUS_USB)
> + ret = sony_set_operational(hdev);
> + else if (hdev->bus == BUS_BLUETOOTH)
> + ret = sony_set_operational_bt(hdev);
> + else
> + ret = 0;
> +
I would do sony_set_operational_usb() and sony_set_operational_bt() and
also turn this into a switch statement for better readability.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 6 of 7 ==
Date: Wed, Feb 3 2010 6:20 am
From: Marcel Holtmann
Hi Jiri,
> In commit 2da31939a42 ("Bluetooth: Implement raw output support for HIDP
> layer"), support for Bluetooth hid_output_raw_report was added, but it
> pushes the data to the intr socket instead of the ctrl one. This has been
> fixed by 6bf8268f9a91f1 ("Bluetooth: Use the control channel for raw HID reports")
>
> Still, it is necessary to distinguish whether the report in question should be
> either FEATURE or OUTPUT. For this, we have to extend the generic HID API,
> so that hid_output_raw_report() callback provides means to specify this
> value so that it can be passed down to lower level hardware drivers (currently
> Bluetooth and USB).
>
> Based on original patch by Bastien Nocera <hadess@hadess.net>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
> drivers/hid/hidraw.c | 2 +-
> drivers/hid/usbhid/hid-core.c | 5 +++--
> include/linux/hid.h | 2 +-
> net/bluetooth/hidp/core.c | 13 ++++++++++---
> 4 files changed, 15 insertions(+), 7 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
> -static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, size_t count)
> +static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, size_t count,
> + unsigned char report_type)
> {
> - if (hidp_send_ctrl_message(hid->driver_data,
> - HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE,
> + if (report_type == HID_FEATURE_REPORT)
> + report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE;
> + else if (report_type == HID_OUTPUT_REPORT)
> + report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;
> + else
> + return -EINVAL;
If you wanna be a little bit more readable, then using a switch
statement helps instead of else if. Just my 2 cents.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
== 7 of 7 ==
Date: Wed, Feb 3 2010 6:30 am
From: Marcel Holtmann
Hi Jiri,
> The hid-wacom driver required user-space to poke at the tablet
> to make it send data about the cursor location.
>
> This patch makes it do the same thing but in the kernel.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> + /* Set Wacom mode2 */
> + rep_data[0] = 0x03; rep_data[1] = 0x00;
> + limit =3;
Small nitpick here. The space after = is missing ;)
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
==============================================================================
TOPIC: tracing: add tracing support for compat syscalls
http://groups.google.com/group/linux.kernel/t/22202c3dcd1a3591?hl=en
==============================================================================
== 1 of 1 ==
Date: Wed, Feb 3 2010 5:00 am
From: Heiko Carstens
On Tue, Feb 02, 2010 at 04:21:51PM -0500, Jason Baron wrote:
> Add core support to event tracing for compat syscalls. The basic idea is that we
> check if we have a compat task via 'is_compat_task()'. If so, we lookup in the
> new compat_syscalls_metadata table, the corresponding struct syscall_metadata, to
> check syscall arguments and whether or not we are enabled.
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
> include/linux/compat.h | 8 +++++
> include/trace/syscall.h | 4 ++
> kernel/trace/trace.h | 2 +
> kernel/trace/trace_syscalls.c | 63 +++++++++++++++++++++++++++++++++++-----
> 4 files changed, 69 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/compat.h b/include/linux/compat.h
> index ef68119..ab2cda2 100644
> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -353,5 +353,13 @@ asmlinkage long compat_sys_newfstatat(unsigned int dfd, char __user * filename,
> asmlinkage long compat_sys_openat(unsigned int dfd, const char __user *filename,
> int flags, int mode);
>
> +#else /* CONFIG_COMPAT */
> +
> +#define NR_syscalls_compat 0
> +static inline int is_compat_task(void)
> +{
> + return 0;
> +}
> +
>

0 Comments:
Post a Comment
Subscribe to Post Comments [Atom]
<< Home