Possible bug with django.contrib.auth.forms

Hi Fellas,

Just wanted to throw this out there to see if this is a bug.

In line 173 of django.contrib.auth.forms:  https://github.com/zhenghao1/django/blob/master/django/contrib/auth/forms.py#L173

I feel this boolean test is too generic.  If I were to deliberately set the username field's label to an empty string, this would still set the label.  

Any thoughts and suggestions?  I am about to send a pull request for this.

Regards,

Zhenghao Huang

--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscribe@googlegroups.com.
To post to this group, send email to django-users@googlegroups.com.
Visit this group at http://groups.google.com/group/django-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.