Re: Possible bug with django.contrib.auth.forms

Actually…. I take this back.

I went digging into the form logic, and discovered that I was incorrect about the empty <label> tag -- there's already logic in place to suppress the <label> if there's no label content. So - I'd say you're correct - the check in AuthenticationForm *should* be an "is None" check to allow for an empty label.

Yours,

Russ Magee %-)

On Tue, May 7, 2013 at 7:50 AM, Russell Keith-Magee <russell@keith-magee.com> wrote:

Hi Zhenghao Huang,

I'm not sure I agree that this is a bug. 

From a purely logical perspective, I agree the an "is None" check would be more rigorous. 

However, allowing the field label to the empty string isn't really a good idea. It won't prevent the <label> markup from being rendered, it will just mean you have an label tag with no content -- something that would be bad from an accessibility point of view.

If you want to silence the printing of the label for some reason, you'd be better served handling it at the rendering level, and omitting the display of the <label> tag. 

For that reason, I'd say the current behaviour is preferable.

Yours,

Russ Magee %-)

On Mon, May 6, 2013 at 7:00 PM, Zhenghao Huang <zhenghao12@gmail.com> wrote:

Hi Fellas,

Just wanted to throw this out there to see if this is a bug.

In line 173 of django.contrib.auth.forms:  https://github.com/zhenghao1/django/blob/master/django/contrib/auth/forms.py#L173

I feel this boolean test is too generic.  If I were to deliberately set the username field's label to an empty string, this would still set the label.  

Any thoughts and suggestions?  I am about to send a pull request for this.

Regards,

Zhenghao Huang

--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscribe@googlegroups.com.
To post to this group, send email to django-users@googlegroups.com.
Visit this group at http://groups.google.com/group/django-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscribe@googlegroups.com.
To post to this group, send email to django-users@googlegroups.com.
Visit this group at http://groups.google.com/group/django-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.