Re: JUnitShell.getModuleUrl() produces invalid URL for IPv6 addresses

On Tuesday, June 18, 2013 11:59:49 AM UTC+2, Maik Riechert wrote:

Hi,

it seems the JUnitShell is generating invalid URLs if IPv6 is used:

http://2607:f700:8000:12d:dd58:687b:744c:800c:48579/...

You can observe this here:
https://travis-ci.org/neothemachine/KineticGWT/builds/8191369#L881

The URL should be 
http://[2607:f700:8000:12d:dd58:687b:744c:800c]:48579/...

Is this a known issue? I couldn't find anything related to that.

I don't think I've seen a bug report about that. This is due to constructing the URL by string concatenations; using java.net.URL or java.net.URI, the brackets could be added automatically if needed (depending on the constructor used).

As a workaround, because you're working on a custom RunStyle, override RunStyle#getLocalHostName to add the brackets when the InetAddress is an Inet6Address.

Feel free to file a bug in the issue tracker. And it'd be awesome if you could provide a patch! (note that there's a similar issue in RunStyleSelenium I guess)

--
You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.