Tuesday, November 12, 2013

Re: gwt-rawhistory on github

I should have mentioned that the example I showed above was for Safari. Firefox does something different:

A link for:

fun/(&)(&)(%26)(%2526)/(%23)/(+)(%2B)(%20)(%252B)(%2520)/%E7%A6%85

becomes:

Safari/Chrome: fun/(&)(&)(%26)(%26)/(#)/(+)(%2B)( )(%2B)(%20)/禅
Firefox: fun/(&)(&)(&)(%26)/(#)/(+)(+)( )(%2B)(%20)/禅

So if you use GWT Anchors or generate links server-side, the value of History.getToken() depends on the browser.

-Andy

On Tuesday, November 12, 2013 8:10:31 AM UTC-5, Andy wrote:
No, I haven't. Thanks for the link!

From a quick glance at the code, it's use of location.hash and encode/decode will likely still cause issues for us. Over the next few days, I'll try to create a version of my demo that uses the new code.

It could be that my expectations are wrong, but I spent a long time back in June 2010 trying to work around the issues we encountered. The example I posted gives you a good idea of the challenge.

A link for:

fun/(&)(&)(%26)(%2526)/(%23)/(+)(%2B)(%20)(%252B)(%2520)/%E7%A6%85

becomes:

fun/(&)(&)(%26)(%26)/(#)/(+)(%2B)( )(%2B)(%20)/禅

%25 %23 %20 and the utf8 char are decoded, but + %26 and %2B are not.

I'm admittedly not an expert in proper hash encode/decode, but the above result seems wrong. I suspect it's something subtle in the combination of HTML decode of the href= attribute and URL decode of that value.

-Andy

On Tuesday, November 12, 2013 4:38:25 AM UTC-5, Thomas Broyer wrote:
Have you seen https://gwt-review.googlesource.com/5356 ?

On Monday, November 11, 2013 5:25:26 PM UTC+1, Andy wrote:
For a while I've been planning to move our gwt-traction library over to github. Over the weekend, I decided to start with RawHistory.

RawHistory is a module that I suspect few people are using. It used to have a note at the bottom saying that someday I'd explain exactly what it did. As part of moving it to github, I implemented a demo.

https://github.com/andykellr/gwt-rawhistory

I'd appreciate any feedback, particularly if you've also run into history token encode/decode issues.

-Andy


--
You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.

0 Comments:

Post a Comment

Subscribe to Post Comments [Atom]

<< Home


Real Estate