linux.kernel - 26 new messages in 20 topics - digest

linux.kernel
http://groups.google.com/group/linux.kernel?hl=en

linux.kernel@googlegroups.com

Today's topics:

* crypto:s5p-sss: Add device tree and Exynos5 support - 4 messages, 1 author
http://groups.google.com/group/linux.kernel/t/f59d361a0fccccf0?hl=en
* cpufreq:boost: CPU Boost mode support - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/4de546f1e6e1312d?hl=en
* mm, memcg: avoid oom notification when current needs access to memory
reserves - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/ddffce70f2a0b5fc?hl=en
* ARM: OMAP: raw read and write endian fix - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/887c0e348ce79bed?hl=en
* Broken locking in leds-lp5523.c - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/b74c7120b450ab82?hl=en
* usbcore: fix BABBLE failed enumeration of legacy USB2 devices on USB3 bus -
1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/b9228cf2e58abcd5?hl=en
* usb: xhci: Link TRB must not occur within a USB payload burst - 1 messages,
1 author
http://groups.google.com/group/linux.kernel/t/02bb633f7aaf9195?hl=en
* xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/cf6b66e5d32612e6?hl=en
* could you clarify mm/mempolicy: fix !vma in new_vma_page() - 1 messages, 1
author
http://groups.google.com/group/linux.kernel/t/38d54ba2f84c0d77?hl=en
* audit: print error message when fail to create audit socket - 2 messages, 2
authors
http://groups.google.com/group/linux.kernel/t/8fbd8b5c750ebef6?hl=en
* media: dvb_core: slight optimization of addr compare - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/85f9ac338444f0d4?hl=en
* regulator: twl: Fix checkpatch issue - 3 messages, 1 author
http://groups.google.com/group/linux.kernel/t/d804830f640cb278?hl=en
* kernfs, sysfs, driver-core: implement synchronous self-removal - 1 messages,
1 author
http://groups.google.com/group/linux.kernel/t/b72ccc5edcdfb313?hl=en
* mm/mlock: fix BUG_ON unlocked page for nolinear VMAs - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e5f2f23671a7c795?hl=en
* powerpc 8xx: defconfig: slice by 4 is more efficient than the default slice
by 8 on Powerpc 8xx. - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/5e167dcdf7be9162?hl=en
* lib/percpu_counter.c: disable local irq when updating percpu couter - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/6ee18c90a650ed65?hl=en
* Terrible performance of sequential O_DIRECT 4k writes in SAN environment. ~3
times slower then Solars 10 with the same HBA/Storage. - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/c2d4038a5c79058e?hl=en
* tty/serial: at91: prevent null dereference in tasklet function - 1 messages,
1 author
http://groups.google.com/group/linux.kernel/t/c33da8b15fea686c?hl=en
* of/platform: Fix no irq domain found errors when populating interrupts - 1
messages, 1 author
http://groups.google.com/group/linux.kernel/t/5c02f1b0dea17622?hl=en
* kexec: reuse 1st kernel as kexec/kdump kernel? - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/deb149363fcb0d3c?hl=en

==============================================================================
TOPIC: crypto:s5p-sss: Add device tree and Exynos5 support
http://groups.google.com/group/linux.kernel/t/f59d361a0fccccf0?hl=en
==============================================================================

== 1 of 4 ==
Date: Tues, Jan 7 2014 4:30 pm
From: Tomasz Figa


Hi Naveen,

Please see my comments inline.

On Tuesday 07 of January 2014 17:21:46 Naveen Krishna Ch wrote:
> This patch adds device tree support along with a new
> compatible string to support Exynos5 SoCs (SSS_VER_5).
>
> Also, Documentation under devicetree/bindings added.
>
> Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com>
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> CC: David S. Miller <davem@davemloft.net>
> CC: Vladimir Zapolskiy <vzapolskiy@gmail.com>
> TO: <linux-crypto@vger.kernel.org>
> CC: <linux-samsung-soc@vger.kernel.org>
> ---
> .../devicetree/bindings/crypto/samsung-sss.txt | 24 ++++++++++++
> drivers/crypto/s5p-sss.c | 40 ++++++++++++++++++++
> 2 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt
> new file mode 100644
> index 0000000..8871a29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt
> @@ -0,0 +1,24 @@
> +Samsung SoC SSS crypto Module

A sentence or two explaining what this module is would be nice.

> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> + SSS versions:
> + - "samsung,exynos-secss" for S5PV210.
> + - "samsung,s5p-secss" for Exynos5 series SoCs.

Hmm, this doesn't make any sense, Exynos for S5PV210 and S5P for
Exynos5...

Please use specific compatible strings containing names of first SoC in
which given compatible IP block appeared. E.g. "samsung,s5pv210-secss"
and "samsung,exynos5250-secss" (if S5PV210 and Exynos5 have been first
respectively).

> + TBD: SSS module on Exynos5 SoCs supports other algorithms,
> + support for the is yet to be added in the driver.

This has nothing to do with DT bindings.

> +- reg : Offset and length of the register set for the module
> +- interrupts : the interrupt-specifier for the SSS module.

It should be specified how many entries should be specified and what are
their meanings.

> +- clocks : the required gating clock for the SSS module.
> +- clock-names : the gating clock name requested in the SSS driver.

The name should be specified and no dependency on the driver should be
made (it's the driver that should follow the bindings, not the other
way around).

> +
> +Example:
> + /* SSS_VER_5 */
> + sss: sss {

Should be sss: sss@10830000 as per ePAPR recommendation about node naming.

> + compatible = "samsung,exynos-secss";
> + reg = <0x10830000 0x10000>;
> + interrupts = <0 112 0>;
> + clocks = <&clock 471>;
> + clock-names = "secss";
> + };
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index dda4551..dcb9fc1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -22,6 +22,7 @@
> #include <linux/scatterlist.h>
> #include <linux/dma-mapping.h>
> #include <linux/io.h>
> +#include <linux/of.h>
> #include <linux/crypto.h>
> #include <linux/interrupt.h>
>
> @@ -173,10 +174,45 @@ struct s5p_aes_dev {
> struct crypto_queue queue;
> bool busy;
> spinlock_t lock;
> +
> + /* To support SSS versions across Samsung SoCs */
> + unsigned int version;
> };
>
> static struct s5p_aes_dev *s5p_dev;
>
> +enum sss_version {
> + SSS_VER_4, /* SSS found on S5PV210 */
> + SSS_VER_5, /* SSS found on Exynos5 Series SoCs */
> +};
> +
> +static struct platform_device_id s5p_sss_ids[] = {

static const struct platform_device_id

> + {
> + .name = "s5p-secss",
> + .driver_data = SSS_VER_4,
> + }, { },
> +};
> +MODULE_DEVICE_TABLE(platform, s5p_sss_ids);
> +

#ifdef CONFIG_OF

> +static struct of_device_id s5p_sss_dt_match[] = {

static const struct of_device_id

> + { .compatible = "samsung,s5p-secss", .data = (void *)SSS_VER_4 },
> + { .compatible = "samsung,exynos-secss", .data = (void *)SSS_VER_5 },

Does this driver already support SSS version 5 at this stage? Aren't
further patches needed for this?

> + { },
> +};
> +MODULE_DEVICE_TABLE(of, s5p_sss_dt_match);