linux.kernel - 26 new messages in 8 topics - digest

linux.kernel
http://groups.google.com/group/linux.kernel?hl=en

linux.kernel@googlegroups.com

Today's topics:

* drm/i2c: tda998x: code optimization - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/0c4bda32b2bb1b2c?hl=en
* clk: support hardware-specific debugfs entries - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/bf0e559d9bc3fafc?hl=en
* perf, tools: Add support for prepending LBRs to the callstack - 3 messages,
2 authors
http://groups.google.com/group/linux.kernel/t/6f4f5573ed92a6c4?hl=en
* Staging: lustre: Use of fls to find last set bit - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/aae84f33e3c0a791?hl=en
* mm: thp: Add per-mm_struct flag to control THP - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/d9fd22ac1fdbf6b3?hl=en
* ARM: s3c64xx: pm: Add always_on field to s3c64xx_pm_domain struct - 10
messages, 1 author
http://groups.google.com/group/linux.kernel/t/63098c6f35af189c?hl=en
* perf, tools: Only print base source file for srcline - 8 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e9ad098f44690ff5?hl=en
* sysfs warnings since kernel 3.13-rc1: "WARNING: ... at fs/sysfs/group.c:214
sysfs_remove_group" - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/a38fa27af05ff8f6?hl=en

==============================================================================
TOPIC: drm/i2c: tda998x: code optimization
http://groups.google.com/group/linux.kernel/t/0c4bda32b2bb1b2c?hl=en
==============================================================================

== 1 of 1 ==
Date: Sat, Jan 11 2014 11:00 am
From: Russell King - ARM Linux


On Thu, Jan 09, 2014 at 12:07:25PM +0100, Jean-Francois Moine wrote:
> This patch reduces the number of I2C exchanges by setting many bits in
> one write and removing a useless write.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index 6b4f6d2..d3b3f3a 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -751,10 +751,10 @@ tda998x_configure_audio(struct tda998x_priv *priv,
> }
>
> reg_write(priv, REG_AIP_CLKSEL, clksel_aip);
> - reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT);
> + reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT |

This patch clearly hasn't even been build tested, so I doubt there's
much point reviewing this or the following patches. From a quick scan
of the following patches, this never got fixed so the following patches
can't have been build tested either.

Thanks.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/





==============================================================================
TOPIC: clk: support hardware-specific debugfs entries
http://groups.google.com/group/linux.kernel/t/bf0e559d9bc3fafc?hl=en
==============================================================================

== 1 of 1 ==
Date: Sat, Jan 11 2014 11:20 am
From: Alex Elder


Add a new clk_ops->debug_init method to allow a clock hardware
driver to populate the clock's debugfs directory with entries
beyond those common for every clock.

Signed-off-by: Alex Elder <elder@linaro.org>
---
v2: - Define debug_init unconditionally (suggested by Gerhard Sittig).

drivers/clk/clk.c | 4 ++++
include/linux/clk-provider.h | 8 ++++++++
2 files changed, 12 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index e3e0327..8769b01 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -277,6 +277,10 @@ static int clk_debug_create_one(struct clk *clk, struct dentry *pdentry)
if (!d)
goto err_out;

+ if (clk->ops->debug_init)
+ if (clk->ops->debug_init(clk->hw, clk->dentry))
+ goto err_out;
+
ret = 0;
goto out;

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 5429f5d..b91674d 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -32,6 +32,7 @@
#define CLK_GET_ACCURACY_NOCACHE BIT(8) /* do not use the cached clk accuracy */

struct clk_hw;
+struct dentry;

/**
* struct clk_ops - Callback operations for hardware clocks; these are to
@@ -116,6 +117,12 @@ struct clk_hw;
* set then clock accuracy will be initialized to parent accuracy
* or 0 (perfect clock) if clock has no parent.
*
+ * @debug_init: Set up type-specific debugfs entries for this clock. This
+ * is called once, after the debugfs directory entry for this
+ * clock has been created. The dentry pointer representing that
+ * directory is provided as an argument. Called with
+ * prepare_lock held. Returns 0 on success, -EERROR otherwise.
+ *
* The clk_enable/clk_disable and clk_prepare/clk_unprepare pairs allow
* implementations to split any work between atomic (enable) and sleepable
* (prepare) contexts. If enabling a clock requires code that might sleep,
@@ -150,6 +157,7 @@ struct clk_ops {
unsigned long (*recalc_accuracy)(struct clk_hw *hw,
unsigned long parent_accuracy);
void (*init)(struct clk_hw *hw);
+ int (*debug_init)(struct clk_hw *hw, struct dentry *dentry);
};

/**
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/





==============================================================================
TOPIC: perf, tools: Add support for prepending LBRs to the callstack
http://groups.google.com/group/linux.kernel/t/6f4f5573ed92a6c4?hl=en
==============================================================================

== 1 of 3 ==
Date: Sat, Jan 11 2014 11:20 am
From: Arnaldo Carvalho de Melo


Em Sat, Jan 11, 2014 at 04:16:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Jan 11, 2014 at 06:58:16PM +0100, Andi Kleen escreveu:
> > On Sat, Jan 11, 2014 at 04:36:14PM +0100, Jiri Olsa wrote:
> > > On Fri, Jan 10, 2014 at 04:32:03AM -0800, Andi Kleen wrote:
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > >
> > > > I never found the default LBR display mode which generates histograms
> > > > of individual branches particularly useful.
> > > >
> > > > This implements an alternative mode that creates histograms over complete
> > > > branch traces, instead of individual branches, similar to how normal
> > > > callgraphs are handled. This is done by putting it in
> > > > front of the normal callgraph and then using the normal callgraph
> > > > histogram infrastructure to unify them.
> > > >
> > > > This way in complex functions we can understand the control flow
> > > > that lead to a particular sample.
> > > >
> > > > The default output is unchanged.
> > > >
> > > > This is only implemented in perf report, no change to record
> > > > or anywhere else.
> > > >
> > > > This adds the basic code to report:
> > > > - add a new "branch" option to the -g option parser to enable this mode
> > > > - when the flag is set include the LBR into the callstack in machine.c.
> > > > The rest of the history code is unchanged and doesn't know the difference
> > > > between LBR entry and normal call entry.
> > >
> > > sounds like nice idea, but I could not get the patchset applied
> > > on acme's perf/core
> >
> > It was on Linus master.
> >
> > I tried to rebase on perf/core, but it seems to be totally broken by
> > itself. All the config tests fail on my opensuse system.
> >
> > Arnaldo?
>
> Oops, checking on some systems...

What was your build command line?

Here, on a f18 system it works with these:

$ make -C tools/perf O=/tmp/build/perf install

$ cd tools/perf ; make

Trying on another system...

- Arnaldo

> > Auto-detecting system features:
> > ... backtrace: [ OFF ]
> > ... dwarf: [ OFF ]
> > ... fortify-source: [ OFF ]
> > ... glibc: [ OFF ]
> > ... gtk2: [ OFF ]
> > ... gtk2-infobar: [ OFF ]
> > ... libaudit: [ OFF ]
> > ... libbfd: [ OFF ]
> > ... libelf: [ OFF ]
> > ... libelf-getphdrnum: [ OFF ]
> > ... libelf-mmap: [ OFF ]
> > ... libnuma: [ OFF ]
> > ... libperl: [ OFF ]
> > ... libpython: [ OFF ]
> > ... libpython-version: [ OFF ]
> > ... libslang: [ OFF ]
> > ... libunwind: [ OFF ]
> > ... on-exit: [ OFF ]
> > ... stackprotector-all: [ OFF ]
> > ... timerfd: [ OFF ]
> >
> > config/Makefile:282: *** No gnu/libc-version.h found, please install
> > glibc-dev[el]/glibc-static. Stop.
> > make: *** [all] Error 2
> >
> > -Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/




== 2 of 3 ==
Date: Sat, Jan 11 2014 11:30 am
From: Arnaldo Carvalho de Melo


Em Sat, Jan 11, 2014 at 06:58:16PM +0100, Andi Kleen escreveu:
> On Sat, Jan 11, 2014 at 04:36:14PM +0100, Jiri Olsa wrote:
> > On Fri, Jan 10, 2014 at 04:32:03AM -0800, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > I never found the default LBR display mode which generates histograms
> > > of individual branches particularly useful.
> > >
> > > This implements an alternative mode that creates histograms over complete
> > > branch traces, instead of individual branches, similar to how normal
> > > callgraphs are handled. This is done by putting it in
> > > front of the normal callgraph and then using the normal callgraph
> > > histogram infrastructure to unify them.
> > >
> > > This way in complex functions we can understand the control flow
> > > that lead to a particular sample.
> > >
> > > The default output is unchanged.
> > >
> > > This is only implemented in perf report, no change to record
> > > or anywhere else.
> > >
> > > This adds the basic code to report:
> > > - add a new "branch" option to the -g option parser to enable this mode
> > > - when the flag is set include the LBR into the callstack in machine.c.
> > > The rest of the history code is unchanged and doesn't know the difference
> > > between LBR entry and normal call entry.
> >
> > sounds like nice idea, but I could not get the patchset applied
> > on acme's perf/core
>
> It was on Linus master.
>
> I tried to rebase on perf/core, but it seems to be totally broken by
> itself. All the config tests fail on my opensuse system.
>
> Arnaldo?

Oops, checking on some systems...

> Auto-detecting system features:
> ... backtrace: [ OFF ]
> ... dwarf: [ OFF ]
> ... fortify-source: [ OFF ]
> ... glibc: [ OFF ]
> ... gtk2: [ OFF ]
> ... gtk2-infobar: [ OFF ]
> ... libaudit: [ OFF ]
> ... libbfd: [ OFF ]
> ... libelf: [ OFF ]
> ... libelf-getphdrnum: [ OFF ]
> ... libelf-mmap: [ OFF ]
> ... libnuma: [ OFF ]
> ... libperl: [ OFF ]
> ... libpython: [ OFF ]
> ... libpython-version: [ OFF ]
> ... libslang: [ OFF ]
> ... libunwind: [ OFF ]
> ... on-exit: [ OFF ]
> ... stackprotector-all: [ OFF ]
> ... timerfd: [ OFF ]
>
> config/Makefile:282: *** No gnu/libc-version.h found, please install
> glibc-dev[el]/glibc-static. Stop.
> make: *** [all] Error 2
>
> -Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/




== 3 of 3 ==
Date: Sat, Jan 11 2014 11:40 am
From: Andi Kleen


> What was your build command line?
>
> Here, on a f18 system it works with these:
>
> $ make -C tools/perf O=/tmp/build/perf install
>
> $ cd tools/perf ; make
>
> Trying on another system...

Sorry for the false alarm. It looks like it was a problem on my side.
Works now.

-andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/





==============================================================================
TOPIC: Staging: lustre: Use of fls to find last set bit
http://groups.google.com/group/linux.kernel/t/aae84f33e3c0a791?hl=en
==============================================================================

== 1 of 1 ==
Date: Sat, Jan 11 2014 11:40 am
From: Monam Agarwal


This introduces fls in lustre/ldlm/ldlm_extent.c
to find the last set bit.

It also fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_extent.c
WARNING: space prohibited before semicolon.

The patch also fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_extent.c
ERROR: trailing statements should be on next line


Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
Changes since v1:
*Incorrect commit message
*Use of fls function

drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c
index ac5d66a..e6fe2cb 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c
@@ -150,10 +150,12 @@ struct ldlm_interval *ldlm_interval_detach(struct ldlm_lock *l)
static inline int lock_mode_to_index(ldlm_mode_t mode)
{
int index;
+ int len;

LASSERT(mode != 0);
LASSERT(IS_PO2(mode));
- for (index = -1; mode; index++, mode >>= 1) ;
+ len = fls(mode);
+ index = len-1;
LASSERT(index < LCK_MODE_NUM);
return index;
}
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/





==============================================================================
TOPIC: mm: thp: Add per-mm_struct flag to control THP
http://groups.google.com/group/linux.kernel/t/d9fd22ac1fdbf6b3?hl=en
==============================================================================

== 1 of 1 ==
Date: Sat, Jan 11 2014 11:40 am
From: Alex Thorlton


On Sat, Jan 11, 2014 at 04:53:37PM +0100, Oleg Nesterov wrote:
> On 01/10, Alex Thorlton wrote:
> >
> > This patch adds an mm flag (MMF_THP_DISABLE) to disable transparent
> > hugepages using prctl. It is based on my original patch to add a
> > per-task_struct flag to disable THP:
>
> I leave the "whether we need this feature" to other reviewers, although
> personally I think it probably makes sense anyway.
>
> But the patch doesn't look nice imho.
>
> > @@ -373,7 +373,15 @@ extern int get_dumpable(struct mm_struct *mm);
> > #define MMF_HAS_UPROBES 19 /* has uprobes */
> > #define MMF_RECALC_UPROBES 20 /* MMF_HAS_UPROBES can be wrong */
> >
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > +#define MMF_THP_DISABLE 21 /* disable THP for this mm */
> > +#define MMF_THP_DISABLE_MASK (1 << MMF_THP_DISABLE)
> > +
> > +#define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK | MMF_THP_DISABLE_MASK)
> > +#else
> > #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK)
> > +