twitter: linux.kernel - 26 new messages in 15 topics

linux.kernel
http://groups.google.com/group/linux.kernel?hl=en

Today's topics:

* KVM: SVM: Make lazy FPU switching work with nested svm - 2 messages, 1
author
http://groups.google.com/group/linux.kernel/t/b608877f8fa7c926?hl=en
* linux-next: Tree for February 18 (media/video/gspca) - 3 messages, 2 authors
http://groups.google.com/group/linux.kernel/t/7bdd522d85af09a0?hl=en
* video_device: don't free_irq() an element past array vpif_obj.dev[] and fix
test - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e868a8fbe7c98eaa?hl=en
* kdb: core for kgdb back end (2 of 2) - 2 messages, 2 authors
http://groups.google.com/group/linux.kernel/t/7d1f7060382d45a9?hl=en
* Separate address translation routines from core SWIOTLB book-keeping - 8
messages, 1 author
http://groups.google.com/group/linux.kernel/t/54adf59d84fb5e5f?hl=en
* Uncool feature for TTM introduced by x86, pat: Use page flags to track
memtypes of RAM pages - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/e6028262be4092ae?hl=en
* add_timer_on: in-kernel users _all_ buggy ? - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/10ba4cd052c77aef?hl=en
* Stupid futex question - 2.6.33-rc7-mmotm0210 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/3418d4e896d1113f?hl=en
* Memory compaction core - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/8f3afebfb2eb60df?hl=en
* x86-32: use SSE for atomic64_read/set if available - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/c7fe1bc8eb70e0f9?hl=en
* rcu: Convert to raw_spinlocks - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/04143237e4f3863b?hl=en
* 2.6.31.12-rt21 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/5a89e5a484626839?hl=en
* powerpc: implement arch_scale_smt_power for Power7 - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/891f3a14ac88e3fb?hl=en
* genericirq: change ack/mask in irq_chip to take irq_desc in addition to irq -
1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/7b1281c0ca4014ea?hl=en
* staging: r8187se: Miscellaneous cleanups - 1 messages, 1 author
http://groups.google.com/group/linux.kernel/t/ff63660903c66f17?hl=en

==============================================================================
TOPIC: KVM: SVM: Make lazy FPU switching work with nested svm
http://groups.google.com/group/linux.kernel/t/b608877f8fa7c926?hl=en
==============================================================================

== 1 of 2 ==
Date: Thurs, Feb 18 2010 8:40 am
From: Joerg Roedel

On Thu, Feb 18, 2010 at 04:55:06PM +0200, Avi Kivity wrote:
> On 02/18/2010 04:51 PM, Alexander Graf wrote:
> >On 18.02.2010, at 12:38, Joerg Roedel wrote:
> >
> >>TDB.
> >TDB? That's not a patch description.
> >
>
> Short for "To De Befined", I presume.

Ups. I just forgot to give this patch a right commit message. I add one
for the next post.

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== 2 of 2 ==
Date: Thurs, Feb 18 2010 8:40 am
From: Joerg Roedel

On Thu, Feb 18, 2010 at 04:32:02PM +0200, Avi Kivity wrote:
> On 02/18/2010 01:38 PM, Joerg Roedel wrote:
> >TDB.
> >
>
> ...
>
> >@@ -973,6 +973,7 @@ static void svm_decache_cr4_guest_bits(struct kvm_vcpu *vcpu)
> >
> > static void update_cr0_intercept(struct vcpu_svm *svm)
> > {
> >+ struct vmcb *vmcb = svm->vmcb;
> > ulong gcr0 = svm->vcpu.arch.cr0;
> > u64 *hcr0 =&svm->vmcb->save.cr0;
> >
> >@@ -984,11 +985,25 @@ static void update_cr0_intercept(struct vcpu_svm *svm)
> >
> >
> > if (gcr0 == *hcr0&& svm->vcpu.fpu_active) {
> >- svm->vmcb->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> >- svm->vmcb->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> >+ vmcb->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> >+ vmcb->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> >+ if (is_nested(svm)) {
> >+ struct vmcb *hsave = svm->nested.hsave;
> >+
> >+ hsave->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> >+ hsave->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> >+ vmcb->control.intercept_cr_read |= svm->nested.intercept_cr_read;
> >+ vmcb->control.intercept_cr_write |= svm->nested.intercept_cr_write;
>
> Why are the last two lines needed?

Because we don't know if the l1 hypervisor wants to intercept cr0. In
this case we need this intercept to stay enabled.

> >+ }
> > } else {
> > svm->vmcb->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
> > svm->vmcb->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
> >+ if (is_nested(svm)) {
> >+ struct vmcb *hsave = svm->nested.hsave;
> >+
> >+ hsave->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
> >+ hsave->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
> >+ }
> > }
> > }
>
> Maybe it's better to call update_cr0_intercept() after a vmexit
> instead, to avoid this repetition, and since the if () may take a
> different branch for the nested guest and guest cr0.

Thinking again about it I am not sure if this is needed at all. At
vmexit emulation we call svm_set_cr0 which itself calls
update_cr0_intercept. I'll try this.

Joerg

==============================================================================
TOPIC: linux-next: Tree for February 18 (media/video/gspca)
http://groups.google.com/group/linux.kernel/t/7bdd522d85af09a0?hl=en
==============================================================================

== 1 of 3 ==
Date: Thurs, Feb 18 2010 8:40 am
From: Randy Dunlap

On 02/18/10 01:49, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20100217:

when CONFIG_INPUT is not enabled:

drivers/media/video/gspca/gspca.c:2345: error: 'struct gspca_dev' has no member named 'input_dev'
drivers/media/video/gspca/gspca.c:2347: error: 'struct gspca_dev' has no member named 'input_dev'

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== 2 of 3 ==
Date: Thurs, Feb 18 2010 8:40 am
From: Randy Dunlap

On 02/18/10 01:49, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20100217:

duplicated function name:

drivers/staging/built-in.o: In function `format_by_fourcc':
(.text+0x5667): multiple definition of `format_by_fourcc'
drivers/media/built-in.o:(.text+0x2d241): first defined here

in drivers/staging/cx25821/ and drivers/media/common/saa7146_video.c

== 3 of 3 ==
Date: Thurs, Feb 18 2010 9:10 am
From: Patrick McHardy

Randy Dunlap wrote:
> On 02/18/10 01:49, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20100217:
>>
>> The net tree lost its build failure but gained a conflict against the kvm
>> tree.
>
>
> include/net/netfilter/nf_conntrack.h:94: error: field 'ct_general' has incomplete type
> include/net/netfilter/nf_conntrack.h:178: error: 'const struct sk_buff' has no member named 'nfct'
> include/net/netfilter/nf_conntrack.h:185: error: implicit declaration of function 'nf_conntrack_put'
> include/net/netfilter/nf_conntrack.h:294: error: 'const struct sk_buff' has no member named 'nfct'
> net/ipv4/netfilter/nf_defrag_ipv4.c:45: error: 'struct sk_buff' has no member named 'nfct'
> net/ipv4/netfilter/nf_defrag_ipv4.c:46: error: 'struct sk_buff' has no member named 'nfct'
>
> CONFIG_NF_CONNTRACK is not enabled
> but CONFIG_NF_DEFRAG_IPV4=y. It is "select"ed by
> NETFILTER_XT_MATCH_SOCKET and NETFILTER_XT_TARGET_TPROXY,
> both of which are enabled.
>
> Hm, NETFILTER_XT_MATCH_SOCKET depends on !NF_CONNTRACK || NF_CONNTRACK.
> Maybe NETFILTER_XT_TARGET_TPROXY needs to do that also. No, that would
> go against that config option's help text:

No, the problem is use of skb->nfct without CONFIG_NF_CONNTRACK.

This patch should fix it.

diff --git a/net/ipv4/netfilter/nf_defrag_ipv4.c b/net/ipv4/netfilter/nf_defrag_ipv4.c
index d498a70..b822ade 100644
--- a/net/ipv4/netfilter/nf_defrag_ipv4.c
+++ b/net/ipv4/netfilter/nf_defrag_ipv4.c
@@ -42,8 +42,10 @@ static enum ip_defrag_users nf_ct_defrag_user(unsigned int hooknum,
{
u16 zone = NF_CT_DEFAULT_ZONE;

+#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
if (skb->nfct)
zone = nf_ct_zone((struct nf_conn *)skb->nfct);
+

twitter

Thursday, February 18, 2010

linux.kernel - 26 new messages in 15 topics - digest

0 Comments:

Post a Comment

About Me

Previous Posts